Skip to content

Adds Security Champion chat / agent mode to provide comprehensive security guidance by integrating Microsoft's Security Development Lifecycle (SDL) practices alongside existing OWASP frameworks.#408

Open
obrocki wants to merge 16 commits intomicrosoft:mainfrom
obrocki:feat/security-champion-agent

Conversation

@obrocki
Copy link

@obrocki obrocki commented Feb 4, 2026

  • Incorporates all 10 Microsoft SDL practices for secure software development
  • Organizes security inspection areas by development lifecycle stage (Design, Code, Build/Deploy, Runtime)
  • Adds guidance for threat modeling, Zero Trust principles, and supply chain security
  • Expands responsibilities to include security design reviews and Secure by Design promotion
  • Maintains existing OWASP Top 10 and OWASP Top 10 for LLM Applications (2025) references

🔒 - Generated by Copilot

Pull Request

Description

Related Issue(s)

#416

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)

Sample Prompts and Usage

image

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

AI Artifact Contributions

  • Used /prompt-analyze to review contribution
  • Addressed all feedback from prompt-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Automated Checks

The following validation commands must pass before merging:

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues
  • Security-related scripts follow the principle of least privilege

Additional Notes

Copilot AI review requested due to automatic review settings February 4, 2026 10:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (adbebe1) to head (4071e05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.03%     
==========================================
  Files          23       23              
  Lines        4475     4475              
==========================================
- Hits         3820     3819       -1     
- Misses        655      656       +1     
Flag Coverage Δ
pester 85.34% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Security Champion agent and comprehensive OWASP security instruction files to integrate Microsoft's Security Development Lifecycle (SDL) practices alongside existing OWASP frameworks. The PR introduces security guidance across the development lifecycle, from design through runtime, with detailed coding standards for both traditional web applications and LLM-specific security concerns.

Changes:

  • Adds Security Champion conversational agent for security-focused code review and advisory
  • Introduces comprehensive OWASP Top 10 secure coding instructions for web applications
  • Adds OWASP Top 10 for LLM Applications (2025) secure coding instructions for AI/ML security

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.

File Description
.github/agents/security-champion.agent.md New conversational agent that serves as a security advisor, integrating Microsoft SDL practices with OWASP frameworks to guide security reviews across all development stages
.github/instructions/owasp-for-web-applications.instructions.md New instruction file providing comprehensive secure coding guidelines based on OWASP Top 10, covering vulnerabilities from access control to SSRF
.github/instructions/owasp-for-llms.instructions.md New instruction file providing LLM-specific security guidelines based on OWASP Top 10 for LLM Applications (2025), covering prompt injection, data leakage, and other AI-specific risks

Copilot AI review requested due to automatic review settings February 4, 2026 14:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings February 4, 2026 14:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@obrocki obrocki marked this pull request as ready for review February 4, 2026 16:24
@obrocki obrocki requested a review from a team as a code owner February 4, 2026 16:24
Copilot AI review requested due to automatic review settings February 4, 2026 16:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

@WilliamBerryiii
Copy link
Member

WilliamBerryiii commented Feb 4, 2026

Hi! A small request: could you update the PR title to include the conventional commit format with scope? This ensures release-please picks it up correctly for the changelog.

Suggested: `feat(agents): add security champion agent with Microsoft SDL practices

Thanks!

@WilliamBerryiii WilliamBerryiii added this to the v2.2.0 milestone Feb 5, 2026
Copy link
Contributor

@katriendg katriendg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This is valuable, there are a few optimizations I feel are relevant before we merge.

  1. Please re-run the /prompt-analyse or prompt-builder agent again and ensure you add your new files to the context, and ask it to review your three files for recommendations. There are several open recommendations you can still apply before we merge.
  2. Evaluate the usage of the .instructions.md files and applyTo. Is it possible to merge into the custom agent instead? Especially for the LLM application instructions we do not want to enforce this upon every single edit of applicable files. Again here the Task-Researcher and/or Prompt Builder agents may help you refactor some of this in an efficient way.
  3. ## Required Phases given this agent has specific phases (in your case Stages), you should be able to easily reformat the agent to follow the phases approach. Also prompt-builder may do this for you.

Hope these make sense!

Copilot AI review requested due to automatic review settings February 5, 2026 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings February 5, 2026 19:48
@obrocki obrocki requested a review from katriendg February 5, 2026 19:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@katriendg
Copy link
Contributor

Thanks for your changes, I think this is looking good for an initial inclusion into experimental pre-release so we can have some active testing, see how it behaves when used together with some of the other instructions and agents.
Please review any open comments and close them, either adopt the recommendation or leave a note and close the comment. Some of the Copilot comments are valid, some you may just want to discard, or simply outdated.
Once all comments are closed I will do a final review and expect Approval soon from my side.

Copilot AI review requested due to automatic review settings February 6, 2026 13:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings February 13, 2026 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings February 13, 2026 16:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

obrocki and others added 15 commits February 13, 2026 16:56
…M applications

- include OWASP Top 10 for LLM Applications (2025) security practices
- outline responsibilities and areas to inspect during development stages
- emphasize security champion mindset and ongoing threat awareness

🔒 - Generated by Copilot
- clarify the directive for secure coding practices
- emphasize the importance of a security-first mindset
- enhance instructions for code reviews and security education

🔒 - Generated by Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…curity champion agent documentation

🔒 - Generated by Copilot
…hampion agent documentation

🔒 - Generated by Copilot
- enhance clarity and structure of security instructions
- add maturity status to both documents
- improve emphasis on security principles and practices
- refine sections for better readability and understanding

🔒 - Generated by Copilot
…d guidance and handoffs

- add security-focused code review purpose and workflow
- include core frameworks and areas covered for security champion agent
- remove maturity status from OWASP instructions for LLM and web applications

🔒 - Generated by Copilot
…arity and structure

- redefine inspection areas as required phases
- clarify flow through development lifecycle phases
- enhance guidance for security reviews and reporting

🔒 - Generated by Copilot
- Remove tools frontmatter to let users choose available tools
- Elaborate agent description for Extension UI visibility
- Add #file: references for OWASP instructions so Copilot follows paths
- Add maturity: experimental to both OWASP instruction files
- Convert bolded-prefix list items to plain text in LLM instructions
- Convert embedding inversion defense list to prose
…tore web applications guidelines

- introduce OWASP Top 10 for LLM Applications with detailed security measures
- restore comprehensive secure coding instructions for web applications
- ensure clear communication of security practices and principles

🔒 - Generated by Copilot
…uctions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…uctions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 13, 2026 16:56
@obrocki obrocki force-pushed the feat/security-champion-agent branch from 673ade6 to c8e2456 Compare February 13, 2026 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

@@ -0,0 +1,226 @@
---
description: "Comprehensive secure coding instructions for all languages and frameworks, based on OWASP Top 10 and industry best practices. Give clear and concise feedback and points of improvement."
maturity: experimental
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontmatter includes a maturity field, which is not allowed according to the instruction-frontmatter.schema.json schema. The schema defines additionalProperties: false and only allows description, name, and applyTo fields. Maturity is tracked in collection manifest items (collections/*.collection.yml), not in individual artifact frontmatter. Remove the maturity field from this frontmatter and instead add this file to an appropriate collection manifest with the maturity specified there.

Suggested change
maturity: experimental

Copilot uses AI. Check for mistakes.
---
description: "When generating, reviewing, or refactoring code that interacts with Large Language Models (LLMs), read and follow these OWASP Top 10 for LLM Applications (2025) secure coding guidelines to protect against prompt injection, data leakage, and LLM-specific vulnerabilities. Apply these instructions to any LLM integration, agent framework, RAG pipeline, or AI-powered feature. Provide clear and concise security feedback and points of improvement."
applyTo: '**/*'
maturity: experimental
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontmatter includes a maturity field, which is not allowed according to the instruction-frontmatter.schema.json schema. The schema defines additionalProperties: false and only allows description, name, and applyTo fields. Maturity is tracked in collection manifest items (collections/*.collection.yml), not in individual artifact frontmatter. Remove the maturity field from this frontmatter and instead add this file to an appropriate collection manifest with the maturity specified there.

Suggested change
maturity: experimental

Copilot uses AI. Check for mistakes.
@WilliamBerryiii WilliamBerryiii modified the milestones: v2.3.0, v2.4.0 Feb 13, 2026
…b applications and LLMs

🔒 - Generated by Copilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants